Update LLVM from upstream#2499
Merged
StephanTLavavej merged 33 commits intomicrosoft:mainfrom Feb 17, 2022
Merged
Conversation
... if it's enabled, it oughta work. As detected by libc++ test `std/utilities/memory/storage.iterator/types.compile.pass.cpp`.
We somehow failed to implement this operation as updated by P1522.
... in `input_or_output_iterator` and `common_with`. The implementations seem to think this affects subsumption, despite that my brain compiler believes they should be equivalent.
We/I failed to notice that LWG changed my proposed resolution before approving. Also relocates `_Require_constant` next to its only remaining use in the `_Tiny_range` concept in `<ranges>`.
Overload resolution falls back on the base class operators when the derived operators disappear.
Since Clang 14 still doesn't support P0960. It was a nice experiment, but it's time to move on.
for `convertible_to`, `common_reference_with`, and `swappable_with` to test with lvalue arrays of volatile elements.
... and fix a bug in `join_view::iterator::_Check_dereference`.
... to support the `join_view` iterator converting constructor.
Test coverage in `libcxx/test/std/utilities/memory/pointer.conversion/to_address.pass.cpp`.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
cpplearner
reviewed
Jan 22, 2022
StephanTLavavej
requested changes
Feb 10, 2022
StephanTLavavej
approved these changes
Feb 11, 2022
Member
|
Casey has mirrored this to MSVC-PR-375314 - any further commits need to be kept in sync. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Feb 15, 2022
miscco
approved these changes
Feb 16, 2022
barcharcraz
approved these changes
Feb 17, 2022
Contributor
barcharcraz
left a comment
barcharcraz
left a comment
There was a problem hiding this comment.
Looks good. I'm not 100% convinced doing the metaprogramming to sidestep the bool comparison warning is better than just letting it fire, as it's probably not something the user intended, but.... the standard does allow boolean widths.
barcharcraz
approved these changes
Feb 17, 2022
StephanTLavavej
approved these changes
Feb 17, 2022
Contributor
Author
|
Porting internally (again), please inform me of any changes (and please just don't). |
StephanTLavavej
approved these changes
Feb 17, 2022
Member
|
Thanks for this massive update fixing a whole bunch of bugs! 😻 🐞 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes fixes for a couple of dozen tiny bugs discovered by new and/or updated tests, and one large update to the skipped tests list / magic_comments used to filter libc++ tests by the internal test runner.
I recommend reviewing by commit.
Fixes #2001.